-
-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paging to the GetBannedPersons
fetch.
#2847
Comments
See #4580 for an example how to implement this. |
Also, we'd like to convert every existing |
When doing this I would change the endpoint to |
Hrm. So far the only two person fetches are listing admins, and listing banned persons, and only banned_persons is its own endpoint. Search can also list persons, but it already has pagination. I think this is one case where I'd prefer specific endpoints, rather than a multi-purpose generic one, because we only have one case of person fetching, and I will make |
I dont see any reason why banned users should be a separate endpoint, its better to do like GetPosts with various filters (banned_only, local_only etc). This has been frequently requested (eg #4419) and would be very useful for small instances. Other frontends could already implement a full user list display with that basic endpoint, and later it could be extended with more filters and sort options. Afaik lemmy-ui only shows the banned users list under |
Alright, as long as its under the admin heading, that'll probably be fine. |
Currently
GetBannedPersons
fetches all banned users. It would be more performant if paging were added to this endpoint.Not a huge deal, since this is only available to admins anyway.
The text was updated successfully, but these errors were encountered: