From 68c23f26ad660c65d9ed547c0a39bde4fe99ca6f Mon Sep 17 00:00:00 2001 From: regulus79 <117475203+regulus79@users.noreply.github.com> Date: Sun, 11 Aug 2024 12:02:00 -0400 Subject: [PATCH 1/3] Fix Sample Clip Reversing --- src/gui/clips/SampleClipView.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gui/clips/SampleClipView.cpp b/src/gui/clips/SampleClipView.cpp index 30f09caa860..8db932b029f 100644 --- a/src/gui/clips/SampleClipView.cpp +++ b/src/gui/clips/SampleClipView.cpp @@ -330,6 +330,8 @@ void SampleClipView::paintEvent( QPaintEvent * pe ) void SampleClipView::reverseSample() { m_clip->m_sample.setReversed(!m_clip->m_sample.reversed()); + const TimePos sample_length = TimePos::fromFrames(m_clip->m_sample.sampleSize(), Engine::framesPerTick()); + m_clip->setStartTimeOffset(m_clip->length() - m_clip->startTimeOffset() - sample_length); Engine::getSong()->setModified(); update(); } From 957a5aee55def53850645958d58501c1072547ff Mon Sep 17 00:00:00 2001 From: regulus79 <117475203+regulus79@users.noreply.github.com> Date: Sat, 7 Sep 2024 16:13:12 -0400 Subject: [PATCH 2/3] Use existing function to get sample length, which takes into account sample rate --- src/gui/clips/SampleClipView.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gui/clips/SampleClipView.cpp b/src/gui/clips/SampleClipView.cpp index 8db932b029f..62711cc84d3 100644 --- a/src/gui/clips/SampleClipView.cpp +++ b/src/gui/clips/SampleClipView.cpp @@ -27,6 +27,7 @@ #include #include #include +#include #include "GuiApplication.h" #include "AutomationEditor.h" @@ -330,8 +331,7 @@ void SampleClipView::paintEvent( QPaintEvent * pe ) void SampleClipView::reverseSample() { m_clip->m_sample.setReversed(!m_clip->m_sample.reversed()); - const TimePos sample_length = TimePos::fromFrames(m_clip->m_sample.sampleSize(), Engine::framesPerTick()); - m_clip->setStartTimeOffset(m_clip->length() - m_clip->startTimeOffset() - sample_length); + m_clip->setStartTimeOffset(m_clip->length() - m_clip->startTimeOffset() - m_clip->sampleLength()); Engine::getSong()->setModified(); update(); } From 3298ef138fa475d25315dc13ceda36ad2b2f5320 Mon Sep 17 00:00:00 2001 From: regulus79 <117475203+regulus79@users.noreply.github.com> Date: Thu, 12 Sep 2024 22:51:08 -0400 Subject: [PATCH 3/3] Remove including QDebug --- src/gui/clips/SampleClipView.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gui/clips/SampleClipView.cpp b/src/gui/clips/SampleClipView.cpp index 62711cc84d3..a7251be8de6 100644 --- a/src/gui/clips/SampleClipView.cpp +++ b/src/gui/clips/SampleClipView.cpp @@ -27,7 +27,6 @@ #include #include #include -#include #include "GuiApplication.h" #include "AutomationEditor.h"