From 2e4a2e4419a976afd56cbcffcddc44c31362dc2a Mon Sep 17 00:00:00 2001 From: Alex Arslan Date: Mon, 29 Apr 2019 15:44:13 -0700 Subject: [PATCH] Stop exporting dot from LinearAlgebra.BLAS LinearAlgebra exports the familiar `dot` function. The BLAS submodule has its own `dot` function, which it also exports, leading to problems if a user tries to access `dot` after `using` both LinearAlgebra and BLAS. Because this conflict currently exists, this change should be non-breaking, as it's difficult to resolve `dot` unqualified from BLAS before it's resolved from LinearAlgebra, so pretty much any consumer must already calling `BLAS.dot` as such. Fixes #31838. --- NEWS.md | 1 + stdlib/LinearAlgebra/src/blas.jl | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index a929a10ab1585..21f0a3281d1a8 100644 --- a/NEWS.md +++ b/NEWS.md @@ -29,6 +29,7 @@ Standard library changes #### LinearAlgebra +* The BLAS submodule no longer exports `dot`, which conflicts with that in LinearAlgebra ([#31838]). * `diagm` and `spdiagm` now accept optional `m,n` initial arguments to specify a size ([#31654]). #### SparseArrays diff --git a/stdlib/LinearAlgebra/src/blas.jl b/stdlib/LinearAlgebra/src/blas.jl index 6f6f77aad375a..12aa6ffdf7eda 100644 --- a/stdlib/LinearAlgebra/src/blas.jl +++ b/stdlib/LinearAlgebra/src/blas.jl @@ -15,7 +15,6 @@ export axpy!, axpby!, blascopy!, - dot, dotc, dotu, scal!,