Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug with empty constructors #85

Open
kragol opened this issue Jul 28, 2023 · 0 comments · May be fixed by #86
Open

bug with empty constructors #85

kragol opened this issue Jul 28, 2023 · 0 comments · May be fixed by #86

Comments

@kragol
Copy link

kragol commented Jul 28, 2023 •
edited
Loading

In src/PooledArrays.jl at lines 202-203, we find the following code

@inline PooledArray(t::Type) = PooledArray(Array(t,0))
@inline PooledArray(t::Type, r::Type) = PooledArray(Array(t,0), r)

which does not work as there is no method Array(::Type,::Int).

I guess the intent was more like Array{t}(undef,0) (or just t[]) instead of Array(t,0).
kragol added a commit to kragol/PooledArrays.jl that referenced this issue Jul 28, 2023
@kragol
fixed bug with empty constructors
004d0e3 
fixes JuliaData#85
@kragol kragol linked a pull request Jul 28, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed bug with empty constructors kragol/PooledArrays.jl
1 participant
@kragol