Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Turn into a monorepo #172

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 22, 2023 · 2 comments · Fixed by #206
Closed
3 tasks done

🛠 Tooling: Turn into a monorepo #172

JoshuaKGoldberg opened this issue Sep 22, 2023 · 2 comments · Fixed by #206
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, there are X project repositories around emojisplosion (soon to be renamed to emoji-blast):

konamimojisplosion (soon to be renamed to konami-emoji-blast) currently includes a React bit built-in. But I'd like to split it into separate packages for each popular frontend library: Angular, Preact, Solid, Svelte, React, Vue, ... and it'd be nice to not have to make an entirely new repository for each of them.

Additional Info

This is now the second personal project I'm looking at turning into a monorepo with a rename: JoshuaKGoldberg/TypeStat#1040 -> JoshuaKGoldberg/TypeStat#1314.
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance 🛠️ status: needs investigation Further research required...? 🔎 labels Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 30, 2023
Closed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 2, 2023
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🛠 Tooling: Consider turning into a monorepo 🛠 Tooling: Turn into a monorepo Mar 27, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 27, 2024
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 and removed status: needs investigation Further research required...? 🔎 labels Mar 29, 2024
This was referenced Mar 29, 2024
Merged
Draft
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for tool.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Mar 31, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg added a commit that referenced this issue Apr 1, 2024
@JoshuaKGoldberg
feat: convert to monorepo with konami-emoji-blast (#206)
dbe5ec3 
## PR Checklist

- [x] Addresses an existing open issue: fixes #172
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/emoji-blast/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/emoji-blast/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Things that need to work for this PR:

- [x] Core `emoji-blast` and `konami-emoji-blast` libraries
- [x] Integrations: Astro, React, TypeDoc
- [x] Knip
- [x] Linting
- [x] Testing
- [x] TypeScript project references: used instead of tsup for `lib/`
outputs and type checking
- [x] Webpack builds: for `dist/`, since the existing projects generally
used it

Things I'm leaving as followups:

- https://github.com/cgradeff/emojisplosion-site
- Release management: I'm thinking Changesets
- Investigating switching from Webpack to something newer/faster
- Test coverage
JoshuaKGoldberg pushed a commit that referenced this issue Apr 1, 2024
@allcontributors
docs: add joshuakgoldberg as a contributor for tool (#209)
611c3d0 
Adds @JoshuaKGoldberg as a contributor for tool.

This was requested by JoshuaKGoldberg [in this
comment](#172 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: convert to monorepo with konami-emoji-blast JoshuaKGoldberg/emoji-blast
1 participant
@JoshuaKGoldberg