Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Storage Network framerate drop when searching item descriptions #1219

Open
ChrisLane opened this issue Mar 19, 2023 · 0 comments
Open

Comments

@ChrisLane
Copy link

ChrisLane commented Mar 19, 2023

Describe the bug
When searching my Simple Storage Network for descriptions on vault items, the game does a lot of processing and my framerate drops.

For example, when I search for "#shovelling" to look for shovelling jewels, the framrate drops.

To Reproduce

  1. Put lots of items in a Simple Storage Network, including lots of vault items and Jewels
  2. Search for a description term that appears in vault items e.g. "#shovelling"

Expected behavior
The framerate should not drop when searching vault item descriptions.

Screenshots or Crash Report
Here's a snapshot I got while using a CPU profiler. It looks like a significant portion of CPU time is spent compiling regex patterns. If possible, this should just be done once.
image

Here's a snapshot exported from VisualVM:
slow-search-snapshot.nps.zip

Info (please complete the following information):

  • World Type: Server
  • The_Vault Version 3.8.0.1681

Additional context
This doesn't happen when searching items that are not from 'The Vault'.

@ChrisLane ChrisLane changed the title Simple Storage Network lag when searching item descriptions Simple Storage Network framerate drop when searching item descriptions Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant