-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDM_PCM-read, irq and set gain function implementation #187
Conversation
Signed-off-by: NikhitaR-IFX <[email protected]>
Signed-off-by: NikhitaR-IFX <[email protected]>
Signed-off-by: NikhitaR-IFX <[email protected]>
Signed-off-by: NikhitaR-IFX <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, with the structure and the API :)
Only the comments on the documentation. Which is generated here:
https://ifx-micropython.readthedocs.io/en/pdm-read-blocking/psoc6/quickref.html#pdm-pcm
Without tests passing, I will postpone a deeper of the code functionality.
docs/psoc6/quickref.rst
Outdated
@@ -633,19 +633,31 @@ Constructor | |||
Methods | |||
------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The headlines need to have 1 level lower (Methods, Constructor, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And to keep consistency with the rest of the classes, I would name this "PDM-PDM bus"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: NikhitaR-IFX <[email protected]>
Signed-off-by: NikhitaR-IFX <[email protected]>
Summary
In this PR, all the below functions are implemented but yet to be fully tested.
In the source file, you will find 4 sections:
Test Status:
All the testin so far is being done manually and is later when successful to be added to HIL.
Note: Based on further testing, I feel changes would happen only to following functions and you may ignore if needed while reviewing the same:
Also I am aware there are printf()/mp_printf() statements in the beginning of every function, but only to help with debugging. This will be replaced later by mplogger_print().