Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix pwm #120

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Bugfix pwm #120

merged 6 commits into from
Feb 13, 2024

Conversation

NikhitaR-IFX
Copy link
Member

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description

  • Fixed calculations in PWM duty_u16 --> get and set functions
  • Set duty_ns using pwm_duty_set_ns()
  • Implemented DUT tests for PWM
  • Removed invert functionality as this is currently not working and enabling this requires more efforts which challenges the current implementation of the module.

Related Issue
DESMAKERS-3621

Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Only missing thing is the docs, making a note that "invert" is not available. Also update any example using "invert".

@NikhitaR-IFX
Copy link
Member Author

Nice 👍 Only missing thing is the docs, making a note that "invert" is not available. Also update any example using "invert".

Thanks for noticing. Done now.

@NikhitaR-IFX NikhitaR-IFX merged commit c31bf8c into ports-psoc6-main Feb 13, 2024
26 checks passed
@NikhitaR-IFX NikhitaR-IFX deleted the bugfix-pwm branch February 13, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants