Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar-item: implement a notification feature #1368

Open
tishoyanchev opened this issue Jul 16, 2024 · 1 comment · May be fixed by #1690
Open

Navbar-item: implement a notification feature #1368

tishoyanchev opened this issue Jul 16, 2024 · 1 comment · May be fixed by #1690
Assignees
@tishoyanchev
Labels
enhancement Adding a new feature or improving existing code

Comments

@tishoyanchev
Copy link
Contributor

tishoyanchev commented Jul 16, 2024 •
edited
Loading

Implement a new notification feature to the Navbar-item by incorporating the number-indicator component, and creating a new number-less dot notification following the Figma design. The notifications should be enabled/disabled via a Prop, and managed via a Prop. Accordingly events should also be emitted with the notification.

Design reference: https://www.figma.com/design/zPvPwPgb4EsYFXKC2nhzSG/Infineon-DDS-%7C-Main?node-id=78573-19&p=f&m=dev
@tishoyanchev tishoyanchev added the enhancement Adding a new feature or improving existing code label Jul 16, 2024
@pfafffabian-ifx
Copy link
Collaborator

One prop notificationCount would be sufficient, right?
If its zero, its basically the same as being disabled.
Or would you rather use two props?

@tishoyanchev tishoyanchev self-assigned this Sep 24, 2024
@tishoyanchev tishoyanchev linked a pull request Jan 20, 2025 that will close this issue
Open
@tishoyanchev tishoyanchev linked a pull request Jan 20, 2025 that will close this issue
navbar-item: implements a notification feature #1690
Open
@tishoyanchev tishoyanchev moved this from Low Priority to Pending Review in Infineon Digital Design System - Public Board Jan 22, 2025
@tishoyanchev tishoyanchev moved this from Pending Review to Mid Priority in Infineon Digital Design System - Public Board Feb 20, 2025
@tishoyanchev tishoyanchev moved this from Mid Priority to In Progress in Infineon Digital Design System - Public Board Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tishoyanchev tishoyanchev

Labels
enhancement Adding a new feature or improving existing code
Projects
Infineon Digital Design System - Public Board
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

navbar-item: implements a notification feature Infineon/infineon-design-system-stencil
2 participants
@tishoyanchev @pfafffabian-ifx