PPSSPP should use its own bundled ffmpeg #84737

vit9696 · 2021-09-05T22:29:00Z

`brew gist-logs <formula>` link OR `brew config` AND `brew doctor` output

Unrelated

I ran brew update and am still able to reproduce my issue.
I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?

I was trying to play games (namely Valkyria Chronicles II) with PPSSPP and used a brew-provided version of PPSSPP.

What happened (include all command output)?

All the videos either stuttered or were unplayable: showed black screen soon after the first frame. There are multiple error messages in the logs like the following:

59:14:295 Odin_Main    E[ME]: HLE/sceMpeg.cpp:1384 UNIMPL sceMpegAvcDecodeFlush(08d571f0)
00:23:691 Odin_Main    E[SCEKERNEL]: HLE/sceKernelThread.cpp:2352 800201a2=sceKernelTerminateThread(2107): already stopped
00:30:271 Odin_Main    E[SCEKERNEL]: HLE/sceKernelThread.cpp:2352 800201a2=sceKernelTerminateThread(2109): already stopped
00:49:131 Odin_Main    E[SCEKERNEL]: HLE/sceKernelThread.cpp:2352 800201a2=sceKernelTerminateThread(2111): already stopped
00:52:142 Odin_Main    E[ME]: HLE/sceMpeg.cpp:1384 UNIMPL sceMpegAvcDecodeFlush(08d571f0)
00:52:243 Odin_Main    E[ME]: HLE/sceMpeg.cpp:1384 UNIMPL sceMpegAvcDecodeFlush(08d571f0)
01:26:443 Odin_Main    E[SCEKERNEL]: HLE/sceKernelThread.cpp:2352 800201a2=sceKernelTerminateThread(2144): already stopped
01:31:434 Odin_Main    E[SCEKERNEL]: HLE/sceKernelThread.cpp:2352 800201a2=sceKernelTerminateThread(2146): already stopped
01:48:812 Odin_Main    E[SCEKERNEL]: HLE/sceKernelThread.cpp:2352 800201a2=sceKernelTerminateThread(2148): already stopped
01:51:797 Odin_Main    E[ME]: HLE/sceMpeg.cpp:1384 UNIMPL sceMpegAvcDecodeFlush(08d571f0)
01:51:896 Odin_Main    E[ME]: HLE/sceMpeg.cpp:1384 UNIMPL sceMpegAvcDecodeFlush(08d571f0)
02:04:811 Odin_Main    E[SCEKERNEL]: HLE/sceKernelThread.cpp:2352 800201a2=sceKernelTerminateThread(2181): already stopped

What did you expect to happen?

I expected the videos to play normally, because I expected brew to use the ffmpeg package bundled within PPSSPP repository. PPSSPP includes a rather heavily modified ffmpeg version, so you cannot just use the system/upstream one. I recompiled PPSSPP manually with its own ffmpeg and this worked perfectly. Fortunately their ffmpeg is static.

Step-by-step reproduction instructions (by running `brew` commands)

1. Open Valkyria Chronicles II in PPSSPP.
2. Let the intro video play.
3. It will stutter quite a lot.

The text was updated successfully, but these errors were encountered:

alebcay · 2021-09-05T23:06:57Z

Just for additional background (for other maintainers/readers), the described issue is tracked upstream at hrydgard/ppsspp#11490.

It sounds like the issue should have been addressed upstream (at least in some situations) by hrydgard/ppsspp#14188, which should already be included in this version of ppsspp. As is often the case, upstream also seems reluctant to fully support/fix this issue for non-patched ffmpeg installations, for various reasons described in the upstream issue.

unknownbrackets · 2021-09-11T06:13:53Z

Some points of clarification:

Additional fixes for FFmpeg 3.1+ hrydgard/ppsspp#14188 is not included in the latest stable release, v1.11.3. It's included in the latest git, which is probably not the version that was used here.
FFmpeg has removed/changed functionality that we relied upon in the latest versions. Additional fixes for FFmpeg 3.1+ hrydgard/ppsspp#14188 includes a workaround, but it will exhibit bugs for games that attempt to render videos in certain ways (I don't currently know of any specific games that do this, but I can and have written a test PSP app that does it.)
The version of FFmpeg we bundle is by no means heavily modified; it's simply FFmpeg 3.0.2. That repo also has some build scripts for cut down binaries and some committed binaries.
We include the binaries of FFmpeg mainly to make PPSSPP easier to build on Windows (it would require msys2 and many steps someone perfectly capable of installing Visual Studio and clicking Run would get scared away by.)

I know package managers always think people are "reluctant" to support the latest APIs because it takes work, but keep in mind that 1400+ PSP games were released and they were all written against Sony APIs for video decoding. Emulation means simulating those APIs, not rewriting the game logic and video looping to use new APIs.

Since the new FFmpeg APIs don't support the features we need to simulate Sony's video API, we're likely to remain reluctant for some time. Probably the end result will eventually be, unfortunately, reinventing the wheel on video decoding and writing our own (maybe copying parts of FFmpeg.)

I get that people shouldn't be writing software to decode video the ways FFmpeg no longer supports. Unfortunately, no one has been able to jump in a time machine and successfully convince Sony and PSP game developers of this. I don't anticipate this changing, so I wouldn't recommend holding your breath for our "reluctance" to end - unless you've got a time machine to change how PSP games were written.

-[Unknown]

alebcay · 2021-09-12T11:56:51Z

Hi @vit9696, PPSSPP 1.1.3_1 is now available via Homebrew with the changes from #84738.

vit9696 · 2021-09-12T12:09:33Z

Yes, thank you for taking your time on that. I will find some time to make PPSSPP release in binary.

vit9696 · 2021-09-12T23:03:15Z

Posted in hrydgard/ppsspp#14839.

vit9696 · 2021-09-18T15:48:13Z

With hrydgard/ppsspp#14839 merged we should get official PPSSPP releases as of 1.12.0. CC @alebcay, @Gcenx.

Can you confirm that the uploaded binaries in the artifacts section work fine on your machines? E.g. from here: https://github.com/hrydgard/ppsspp/runs/3639392538.
Shall we rename ppsspp from brew to some other name to instead use a cask?

vit9696 · 2021-10-12T22:19:53Z

@alebcay @Gcenx, from now on PPSSPP provides official binary releases for macOS. What should our route be to include PPSSPP in Homebrew Cask? I see the following options:

We remove ppsspp formula and create ppsspp cask as a replacement.
We rename ppsspp formula to ppsspp-cli and add ppsspp cask.
We add ppsspp-app cask.

My personal preference is route (2), but I am not sure of the general Homebrew policy here.

Gcenx · 2021-10-12T23:10:08Z

@vit9696 if the cmake file is to be believed (10.8 min target), I’d opt for dropping the brew formula and instead provide a cask as ppsspp is a GUI app and not really a cli app. (I believe that’s how brew maintainers would see this)

Off topic but the minimum target should really be 10.9 when using -stdlib=libc++

carlocab · 2021-10-12T23:17:37Z

You can also call the cask ppsspp without renaming the formula. I suggest you try this first.

unknownbrackets · 2021-10-12T23:27:39Z

Off topic but the minimum target should really be 10.9 when using -stdlib=libc++

Used to be 10.7, which was the minimum for libc++. We only upped to 10.8 as of last year. I don't think we've heard any complaints from people using 10.8 or people who were using 10.7 before that (that said, macOS is eclipsed by Android and Windows in usage, by far... it's not impossible that the few people still on 10.8 haven't said anything.)

-[Unknown]

Gcenx · 2021-10-12T23:41:23Z

Used to be 10.7, which was the minimum for libc++. We only upped to 10.8 as of last year. I don't think we've heard any complaints from people using 10.8 or people who were using 10.7 before that (that said, macOS is eclipsed by Android and Windows in usage, by far... it's not impossible that the few people still on 10.8 haven't said anything.)

While true libc++ on 10.7 is rather lacking when compared to 10.8 but Apple sets the minimum target to 10.9 for modern SDKs in most cases. Still I'd be surprised if there's many users still using below 10.11 these days.

vit9696 · 2021-10-13T00:19:41Z

Actually this is not compatible with 10.8, but not due to libc++.

Date/Time:       2021-10-13 00:06:13.923 +0000
OS Version:      Mac OS X 10.8.5 (12F2560)
Report Version:  10

Dyld Error Message:
  Symbol not found: _OBJC_CLASS_$_CAMetalLayer
  Referenced from: /Users/USER/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL
  Expected in: /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore
 in /Users/USER/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL

Date/Time:       2021-10-13 03:08:08.835 +0300
OS Version:      Mac OS X 10.9.5 (13F1911)
Report Version:  11
Anonymous UUID:  ABB5B1A7-0D4F-75FB-BA5B-C94051C63886

Dyld Error Message:
  Symbol not found: _OBJC_CLASS_$_CAMetalLayer
  Referenced from: /Users/USER/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL
  Expected in: /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore
 in /Users/USER/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL

Date/Time:             2021-10-13 03:09:52.434 +0300
OS Version:            Mac OS X 10.10.5 (14F2511)
Report Version:        11
Anonymous UUID:        4C4D268E-45EF-BDE5-4440-BFDA3F7D9A72

Dyld Error Message:
  Symbol not found: _OBJC_CLASS_$_CAMetalLayer
  Referenced from: /Users/USER/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL
  Expected in: /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore
 in /Users/USER/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL

Date/Time:             2021-10-13 01:11:11.106 +0100
OS Version:            Mac OS X 10.11.6 (15G22010)
Report Version:        11
Anonymous UUID:        BE6B860F-08FB-8D00-B45A-8D31959E34BE

Dyld Error Message:
  Symbol not found: ____chkstk_darwin
  Referenced from: /Users/USER/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL
  Expected in: /usr/lib/libSystem.B.dylib

Date/Time:             2021-10-12 17:13:32.135 -0700
OS Version:            Mac OS X 10.12.6 (16G2136)
Report Version:        12
Anonymous UUID:        D7F251E8-F25B-F3F1-FC4A-C8C64D011EC3

Dyld Error Message:
  Symbol not found: ____chkstk_darwin
  Referenced from: /Users/USER/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL
  Expected in: /usr/lib/libSystem.B.dylib

10.13 shows a warning: You can’t use this version of the application “PPSSPPSDL” with this version of macOS. You have macOS 10.13.6. The application requires macOS 10.15 or later. Running from terminal crashes:

dyld: lazy symbol binding failed: Symbol not found: ____chkstk_darwin
  Referenced from: /Users/user/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL (which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: ____chkstk_darwin
  Referenced from: /Users/user/Desktop/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL (which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libSystem.B.dylib

10.14 shows a warning: You can’t use this version of the application “PPSSPPSDL” with this version of macOS. You have macOS 10.14.6. The application requires macOS 10.15 or later.. Running from terminal works fine.

unknownbrackets · 2021-10-13T00:23:15Z

Hmm, I see. Seems like when Metal was added, it wasn't done in a way that preserves older macOS - I guess no one has reported anything even from 10.14... so I guess that was in hrydgard/ppsspp#12583.

Not sure if the latter issues are a target issue or maybe an issue with the library, similarly?

In that case we should indeed either raise the min or fix it. But that's more a PPSSPP problem than here.

-[Unknown]

vit9696 · 2021-10-13T00:32:28Z

PPSSPP is built without -mmacosx-version-min=10.8, that is the problem. I see the following command embedded into PPSSPPSDL. If it is added back, I believe the binaries should work fine.

vit9696 · 2021-10-19T10:27:13Z

PPSSPP 1.12.3 with legacy macOS fixes landed upstream. Shall we drop the formula and switch to casks?

vit9696 added the bug Reproducible Homebrew/homebrew-core bug label Sep 5, 2021

vit9696 mentioned this issue Sep 5, 2021

ppsspp: do not use system ffmpeg as it breaks games #84738

Closed

4 tasks

BrewTestBot closed this as completed in 8df0af1 Sep 12, 2021

vit9696 mentioned this issue Oct 13, 2021

Fix macOS 10.8~10.15 run compatibility hrydgard/ppsspp#15012

Merged

vit9696 mentioned this issue Nov 1, 2021

ppsspp: initial version Homebrew/homebrew-cask#113569

Merged

9 tasks

github-actions bot added the outdated PR was locked due to age label Nov 19, 2021

github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PPSSPP should use its own bundled ffmpeg #84737

PPSSPP should use its own bundled ffmpeg #84737

vit9696 commented Sep 5, 2021

alebcay commented Sep 5, 2021

unknownbrackets commented Sep 11, 2021

alebcay commented Sep 12, 2021

vit9696 commented Sep 12, 2021

vit9696 commented Sep 12, 2021

vit9696 commented Sep 18, 2021

vit9696 commented Oct 12, 2021

Gcenx commented Oct 12, 2021

carlocab commented Oct 12, 2021 •

edited

Loading

unknownbrackets commented Oct 12, 2021

Gcenx commented Oct 12, 2021

vit9696 commented Oct 13, 2021

unknownbrackets commented Oct 13, 2021

vit9696 commented Oct 13, 2021

vit9696 commented Oct 19, 2021 •

edited

Loading

PPSSPP should use its own bundled ffmpeg #84737

PPSSPP should use its own bundled ffmpeg #84737

Comments

vit9696 commented Sep 5, 2021

brew gist-logs <formula> link OR brew config AND brew doctor output

What were you trying to do (and why)?

What happened (include all command output)?

What did you expect to happen?

Step-by-step reproduction instructions (by running brew commands)

alebcay commented Sep 5, 2021

unknownbrackets commented Sep 11, 2021

alebcay commented Sep 12, 2021

vit9696 commented Sep 12, 2021

vit9696 commented Sep 12, 2021

vit9696 commented Sep 18, 2021

vit9696 commented Oct 12, 2021

Gcenx commented Oct 12, 2021

carlocab commented Oct 12, 2021 • edited Loading

unknownbrackets commented Oct 12, 2021

Gcenx commented Oct 12, 2021

vit9696 commented Oct 13, 2021

unknownbrackets commented Oct 13, 2021

vit9696 commented Oct 13, 2021

vit9696 commented Oct 19, 2021 • edited Loading

`brew gist-logs <formula>` link OR `brew config` AND `brew doctor` output

Step-by-step reproduction instructions (by running `brew` commands)

carlocab commented Oct 12, 2021 •

edited

Loading

vit9696 commented Oct 19, 2021 •

edited

Loading