Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12880] Asset download doesn't work with 3D Tiles #12454

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Jul 29, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from giohappy July 29, 2024 15:58
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 29, 2024
@giohappy giohappy marked this pull request as draft July 30, 2024 08:05
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.15%. Comparing base (2e4dae2) to head (cfc4b60).
Report is 67 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12454      +/-   ##
==========================================
- Coverage   64.16%   64.15%   -0.01%     
==========================================
  Files         888      888              
  Lines       53465    53464       -1     
  Branches     6596     6597       +1     
==========================================
- Hits        34304    34299       -5     
- Misses      17651    17654       +3     
- Partials     1510     1511       +1     

@mattiagiupponi mattiagiupponi marked this pull request as ready for review July 30, 2024 08:16
@mattiagiupponi mattiagiupponi self-assigned this Jul 30, 2024
@giohappy giohappy linked an issue Feb 6, 2025 that may be closed by this pull request
@giohappy giohappy changed the title Fix download urls [Fixes #12880] Asset download doesn't work with 3D Tiles Feb 6, 2025
@giohappy giohappy merged commit e5bb6b7 into master Feb 6, 2025
16 of 17 checks passed
@giohappy giohappy deleted the fix_downloaddataset branch February 6, 2025 11:00
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
* Fix download urls

* Fix download urls

* Fix download urls

(cherry picked from commit e5bb6b7)
giohappy added a commit that referenced this pull request Feb 6, 2025
giohappy added a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.4.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset download doesn't work with 3D Tiles
2 participants