Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Nene Icons #3051

Closed
2 tasks done
JVNpixels opened this issue Jul 22, 2024 · 11 comments
Closed
2 tasks done

Enhancement: Nene Icons #3051

JVNpixels opened this issue Jul 22, 2024 · 11 comments
Labels
status: rejected Issue did not pass review or PR cannot be approved. topic: polish Involves minor polish to the UI or gameplay. type: enhancement Involves an enhancement or new feature.

Comments

@JVNpixels
Copy link
Contributor

JVNpixels commented Jul 22, 2024

Issue Checklist

  • I have properly named the enhancement
  • I have checked the issues/discussions pages to see if the enhancement has been previously suggested

What is your suggestion, and why should it be implemented?

My suggestion

  • Add a pixelated icon for nene, even if it’s not used in Freeplay, it would make the character selector menu in the Chart Editor look cleaner and nicer.
  • Maybe an actual icon as well.
@JVNpixels JVNpixels added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Jul 22, 2024
@Cartridge-Man
Copy link
Contributor

Ngl if Nene actually was the opponent or became playable this would be used, and if it’s the case where she is just a gf skin, well then this would be just an unnecessary image taking up a bit of storage for no reason

@Cartridge-Man
Copy link
Contributor

Basically just a waste of the user’s memory lol since it just adds more to the file size which might not sound bad, but it’s something that’s not even gonna be used

@JVNpixels JVNpixels changed the title Enhancement: Nene Chart Editor Icon Enhancement: Nene Icons Jul 28, 2024
@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Jul 28, 2024

Basically just a waste of the user’s memory lol since it just adds more to the file size which might not sound bad, but it’s something that’s not even gonna be used

The heaviest Freeplay icon is less than 800 bytes, meanwhile there's unused files in the week1 folder that only serve as Easter eggs that are up to hundreds of kilobytes. I don't see why that would matter.

@JVNpixels
Copy link
Contributor Author

JVNpixels commented Jul 28, 2024

Thank you I was about to say that, and you made some better points!

@Cartridge-Man
Copy link
Contributor

Okay, good point but I still believe that they’re probably not gonna add it since it won’t even be used, so what’s the point of adding it, the Easter eggs are there for a reason, they’re jokes. An icon that just sits there not being used just seems unnecessary to me

@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Jul 29, 2024

won't even be used

Screenshot 2024-07-28 at 8 55 32 PM

@Cartridge-Man
Copy link
Contributor

I’m talking about the case in which yeah, it’ll be used HERE but it will be useless because Nene probably won’t become playable or an opponent therefore she doesn’t get a free play icon as well as chart editor icon and so why even have a icon for her if it’s not gonna be used in the case that your a casual player who will never see that unless they program and use the chart editor all the time

@Lasercar
Copy link
Contributor

Lasercar commented Feb 4, 2025

Well, if it wouldn't be used, that doesn't mean that it also wouldn't be used for a mod, hell, maybe it ends up inspiring a mod to be created for using it.

@Hundrec Hundrec added the topic: chart editor Related to the operation of the Chart Editor. label Feb 4, 2025
@AbnormalPoof AbnormalPoof added topic: polish Involves minor polish to the UI or gameplay. and removed topic: chart editor Related to the operation of the Chart Editor. labels Feb 4, 2025
@amyspark-ng
Copy link
Contributor

if she ever becomes an opponent/playable against, she'll have an icon (it will most likely be the case) so just be patient

@EliteMasterEric EliteMasterEric closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2025
@amyspark-ng
Copy link
Contributor

😨

@AbnormalPoof AbnormalPoof added status: rejected Issue did not pass review or PR cannot be approved. and removed status: pending triage Awaiting review. labels Mar 27, 2025
@JVNpixels
Copy link
Contributor Author

story of my life lol (its okay but its happened so many times)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved. topic: polish Involves minor polish to the UI or gameplay. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

8 participants