From ac58ead759038585dedb7a1ba183e855770f264b Mon Sep 17 00:00:00 2001
From: Kalpesh Rane <krane-c@eightfold.ai>
Date: Mon, 6 Jan 2025 16:10:30 +0530
Subject: [PATCH 1/4] fix: dropdown: removed outer container tabindex
---
src/components/Dropdown/Dropdown.tsx | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/components/Dropdown/Dropdown.tsx b/src/components/Dropdown/Dropdown.tsx
index 094a2b0b..8cc048ac 100644
--- a/src/components/Dropdown/Dropdown.tsx
+++ b/src/components/Dropdown/Dropdown.tsx
@@ -392,7 +392,6 @@ export const Dropdown: FC<DropdownProps> = React.memo(
ref={refs.setFloating}
style={dropdownStyles}
className={dropdownClasses}
- tabIndex={0}
onClick={
closeOnDropdownClick ? toggle(false, showDropdown) : null
}
From c279c6d2554e8dd8fc555b3fbb4106bc5d344896 Mon Sep 17 00:00:00 2001
From: Kalpesh Rane <krane-c@eightfold.ai>
Date: Wed, 8 Jan 2025 10:32:28 +0530
Subject: [PATCH 2/4] fix: dropdown: introduced overlaywrapper tabindex prop
---
src/components/Dropdown/Dropdown.tsx | 2 ++
src/components/Dropdown/Dropdown.types.ts | 5 +++++
2 files changed, 7 insertions(+)
diff --git a/src/components/Dropdown/Dropdown.tsx b/src/components/Dropdown/Dropdown.tsx
index 8cc048ac..b0af0984 100644
--- a/src/components/Dropdown/Dropdown.tsx
+++ b/src/components/Dropdown/Dropdown.tsx
@@ -75,6 +75,7 @@ export const Dropdown: FC<DropdownProps> = React.memo(
trigger = 'click',
visible,
width,
+ overlayWrapperTabIndex = 0,
},
ref: React.ForwardedRef<DropdownRef>
) => {
@@ -392,6 +393,7 @@ export const Dropdown: FC<DropdownProps> = React.memo(
ref={refs.setFloating}
style={dropdownStyles}
className={dropdownClasses}
+ tabIndex={overlayWrapperTabIndex}
onClick={
closeOnDropdownClick ? toggle(false, showDropdown) : null
}
diff --git a/src/components/Dropdown/Dropdown.types.ts b/src/components/Dropdown/Dropdown.types.ts
index 91701ee4..ee7810cb 100644
--- a/src/components/Dropdown/Dropdown.types.ts
+++ b/src/components/Dropdown/Dropdown.types.ts
@@ -88,6 +88,11 @@ export interface DropdownProps {
* The dropdown content
*/
overlay?: React.ReactElement;
+ /**
+ * The tabindex of the overlay wrapper
+ * @default 0
+ */
+ overlayWrapperTabIndex?: number;
/**
* Placement of the menu
* @default bottom-start
From 1cf59b6e6f6983582242b00f8b8d4cf80c250d7f Mon Sep 17 00:00:00 2001
From: Kalpesh Rane <krane-c@eightfold.ai>
Date: Wed, 15 Jan 2025 10:04:15 +0530
Subject: [PATCH 3/4] fix: dropdown: simplified propname
---
src/components/Dropdown/Dropdown.tsx | 4 ++--
src/components/Dropdown/Dropdown.types.ts | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/components/Dropdown/Dropdown.tsx b/src/components/Dropdown/Dropdown.tsx
index b0af0984..f504b15a 100644
--- a/src/components/Dropdown/Dropdown.tsx
+++ b/src/components/Dropdown/Dropdown.tsx
@@ -75,7 +75,7 @@ export const Dropdown: FC<DropdownProps> = React.memo(
trigger = 'click',
visible,
width,
- overlayWrapperTabIndex = 0,
+ overlayTabIndex = 0,
},
ref: React.ForwardedRef<DropdownRef>
) => {
@@ -393,7 +393,7 @@ export const Dropdown: FC<DropdownProps> = React.memo(
ref={refs.setFloating}
style={dropdownStyles}
className={dropdownClasses}
- tabIndex={overlayWrapperTabIndex}
+ tabIndex={overlayTabIndex}
onClick={
closeOnDropdownClick ? toggle(false, showDropdown) : null
}
diff --git a/src/components/Dropdown/Dropdown.types.ts b/src/components/Dropdown/Dropdown.types.ts
index ee7810cb..01f7ef7d 100644
--- a/src/components/Dropdown/Dropdown.types.ts
+++ b/src/components/Dropdown/Dropdown.types.ts
@@ -92,7 +92,7 @@ export interface DropdownProps {
* The tabindex of the overlay wrapper
* @default 0
*/
- overlayWrapperTabIndex?: number;
+ overlayTabIndex?: number;
/**
* Placement of the menu
* @default bottom-start
From 6f1e6be5e527dcb596212083bb92efaebe9b2ea6 Mon Sep 17 00:00:00 2001
From: Kalpesh Rane <krane-c@eightfold.ai>
Date: Wed, 15 Jan 2025 12:01:49 +0530
Subject: [PATCH 4/4] fix: dropdown: updated snapshots
---
.../__snapshots__/RangePicker.test.js.snap | 30 ++++
.../Tests/__snapshots__/range.test.tsx.snap | 132 ++++++++++++++++++
.../Select/__snapshots__/Select.test.tsx.snap | 13 ++
3 files changed, 175 insertions(+)
diff --git a/src/components/DateTimePicker/DatePicker/Tests/__snapshots__/RangePicker.test.js.snap b/src/components/DateTimePicker/DatePicker/Tests/__snapshots__/RangePicker.test.js.snap
index 5d44694c..fa454033 100644
--- a/src/components/DateTimePicker/DatePicker/Tests/__snapshots__/RangePicker.test.js.snap
+++ b/src/components/DateTimePicker/DatePicker/Tests/__snapshots__/RangePicker.test.js.snap
@@ -14,6 +14,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
@@ -27,12 +28,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -64,6 +67,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
@@ -77,12 +81,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -254,6 +260,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
@@ -267,12 +274,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -410,6 +419,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
@@ -423,12 +433,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -464,6 +476,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
@@ -477,12 +490,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -627,6 +642,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
@@ -640,12 +656,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -788,6 +806,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
@@ -801,12 +820,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -842,6 +863,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
@@ -855,12 +877,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1005,6 +1029,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
@@ -1018,12 +1043,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1059,6 +1086,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
@@ -1072,12 +1100,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
diff --git a/src/components/DateTimePicker/Internal/Tests/__snapshots__/range.test.tsx.snap b/src/components/DateTimePicker/Internal/Tests/__snapshots__/range.test.tsx.snap
index fcea67f4..dfc0e770 100644
--- a/src/components/DateTimePicker/Internal/Tests/__snapshots__/range.test.tsx.snap
+++ b/src/components/DateTimePicker/Internal/Tests/__snapshots__/range.test.tsx.snap
@@ -14,6 +14,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -27,12 +28,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -64,6 +67,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -77,12 +81,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -240,6 +246,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -253,12 +260,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -382,6 +391,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -395,12 +405,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -436,6 +448,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -449,12 +462,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -585,6 +600,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -598,12 +614,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -732,6 +750,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -745,12 +764,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -786,6 +807,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -799,12 +821,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -935,6 +959,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -948,12 +973,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -989,6 +1016,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1002,12 +1030,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1136,6 +1166,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1149,12 +1180,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1190,6 +1223,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1203,12 +1237,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1395,6 +1431,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1408,12 +1445,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1445,6 +1484,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1458,12 +1498,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1546,6 +1588,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1559,12 +1602,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1613,6 +1658,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1626,12 +1672,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1667,6 +1715,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1680,12 +1729,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1741,6 +1792,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1754,12 +1806,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1813,6 +1867,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1826,12 +1881,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -1867,6 +1924,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -1880,12 +1938,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -2054,6 +2114,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -2067,12 +2128,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -2104,6 +2167,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -2117,12 +2181,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -2205,6 +2271,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -2218,12 +2285,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -2272,6 +2341,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -2285,12 +2355,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -2326,6 +2398,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -2339,12 +2412,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -2400,6 +2475,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -2413,12 +2489,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -2472,6 +2550,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -2485,12 +2564,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -2526,6 +2607,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -2539,12 +2621,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3174,6 +3258,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3187,12 +3272,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3224,6 +3311,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3237,12 +3325,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3325,6 +3415,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3338,12 +3429,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3392,6 +3485,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3405,12 +3499,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3446,6 +3542,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3459,12 +3556,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3520,6 +3619,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3533,12 +3633,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3592,6 +3694,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3605,12 +3708,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3646,6 +3751,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3659,12 +3765,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3745,6 +3853,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3758,12 +3867,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3795,6 +3906,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3808,12 +3920,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3896,6 +4010,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3909,12 +4024,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -3963,6 +4080,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -3976,12 +4094,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -4017,6 +4137,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -4030,12 +4151,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -4091,6 +4214,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -4104,12 +4228,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -4163,6 +4289,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -4176,12 +4303,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
@@ -4217,6 +4346,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
+ "aria-label": "",
"autocomplete": "off",
"placeholder": "",
"size": "12",
@@ -4230,12 +4360,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
+ "aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
diff --git a/src/components/Select/__snapshots__/Select.test.tsx.snap b/src/components/Select/__snapshots__/Select.test.tsx.snap
index d5ffc4b9..a1650695 100644
--- a/src/components/Select/__snapshots__/Select.test.tsx.snap
+++ b/src/components/Select/__snapshots__/Select.test.tsx.snap
@@ -44,6 +44,7 @@ exports[`Select Renders empty options in multiple mode without crashing 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"
@@ -121,6 +122,7 @@ exports[`Select Renders empty options in single mode without crashing 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"
@@ -198,6 +200,7 @@ exports[`Select Renders null options in multiple mode without crashing 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"
@@ -275,6 +278,7 @@ exports[`Select Renders null options in single mode without crashing 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"
@@ -352,6 +356,7 @@ exports[`Select Renders with default value 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"
@@ -499,6 +504,7 @@ exports[`Select Renders with default values when multiple 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"
@@ -576,6 +582,7 @@ exports[`Select Renders without crashing 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"
@@ -652,6 +659,7 @@ exports[`Select Select is large 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-large icon-left"
role="presentation"
@@ -727,6 +735,7 @@ exports[`Select Select is medium 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"
@@ -802,6 +811,7 @@ exports[`Select Select is pill shaped 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium round-shape icon-left"
role="presentation"
@@ -877,6 +887,7 @@ exports[`Select Select is rectangle shaped 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"
@@ -952,6 +963,7 @@ exports[`Select Select is small 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-small icon-left"
role="presentation"
@@ -1027,6 +1039,7 @@ exports[`Select Select is underline shaped 1`] = `
/>
<button
aria-disabled="false"
+ aria-hidden="true"
aria-label="Toggle dropdown"
class="icon-button right-icon button button-system-ui transparent button-medium icon-left"
role="presentation"