fix(rich-text-link): Markdown pasting broken with conflicting linkOnPaste option
#411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfgamaral
added
the
👀 Show PR
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
doistbot
added a commit
that referenced
this pull request
Aug 28, 2023
## [1.4.8](v1.4.7...v1.4.8) (2023-08-28) ### Bug Fixes * **rich-text-link:** Markdown pasting broken with conflicting `linkOnPaste` option ([#411](#411)) ([2df2ba9](2df2ba9))
|
🎉 This PR is included in version 1.4.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
With the latest Tiptap version (#407), the Link extension came with a new built-in
linkOnPasteoption (default:true), which conflicted with our own paste rules with support for Markdown syntax (in theRichTextLinkextension), and our ownPasteMarkdownextension with full support for Markdown pasting.This PR simply forces
linkOnPasteto befalse, and disallows the option from being set totruein consumer apps. This is a workaround, as I believe thislinkOnPasteoption is not working as expected, and made an upstream comment about it here. If this is eventually fixed/improved in Tiptap, we can probably revert this change.Making this a
showPR so that I can push a quick fix to Todoist and Twist (we already started receiving reports about this).PR Checklist
Test plan
Rich-text → Defaultstory[Doist](https://doist.dev)Ctrl + Shift + V(or the macOS equivalent)Demo