Skip to content
This repository has been archived by the owner on Oct 29, 2020. It is now read-only.

Update Reportback class __construct() #4703

Closed
weerd opened this issue Jul 17, 2015 · 1 comment
Closed

Update Reportback class __construct() #4703

weerd opened this issue Jul 17, 2015 · 1 comment

Comments

@weerd
Copy link
Contributor

weerd commented Jul 17, 2015

The __construct() function in the Reportback class currently does a lot of extra work whenever the class is instantiated. This is useful for when creating a new Reportback, but conflicts when just loading reportbacks via the class and the construct method always runs first. So best to move this code out of the constructor to avoid having multiple of the same DB queries happening in a single instantiation. If loading Reportbacks in other template code, then replace code to use new class methods to get Reportback data (get() or find()).

@angaither
Copy link
Contributor

same as #6167 we don't need this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants