[Bybit] Changed bybit exchange names (#802)

* Implementation of Bybit V5 unified API

Implemented main private and public methods, some public (candles and orderbook) and private WebSockets. A decision was made to split spot, inverse, linear, and option branches into different APIs because: 1) market symbols intersect, 2) there are no any method to get all the markets (all orders, all positions) from different branches in one call. Branches behave as separate exchanges.

* [Bybit] Changed bybit exchange names

Added custom names instead of generic Bybit that was used previously,  to get bybit exchange branches by name in ExchangeAPI.GetExchangeAPIAsync<>(). Also minor refactoring.

src/ExchangeSharp/API/Exchanges/Bybit/ExchangeBybitInverseAPI.cs

@@ -5,7 +5,6 @@
 
 namespace ExchangeSharp
 {
-	[ApiName(ExchangeName.Bybit)]
 	public class ExchangeBybitInverseAPI : ExchangeBybitV5Base
 	{
 		protected override MarketCategory MarketCategory => MarketCategory.Inverse;
@@ -18,4 +17,5 @@ public ExchangeBybitInverseAPI(bool isUnifiedAccount)
 			IsUnifiedAccount = isUnifiedAccount;
 		}
 	}
+	public partial class ExchangeName { public const string BybitInverse = "BybitInverse"; }
 }

src/ExchangeSharp/API/Exchanges/Bybit/ExchangeBybitLinearAPI.cs

@@ -5,7 +5,6 @@
 
 namespace ExchangeSharp
 {
-	[ApiName(ExchangeName.Bybit)]
 	public class ExchangeBybitLinearAPI : ExchangeBybitV5Base
 	{
 		protected override MarketCategory MarketCategory => MarketCategory.Linear;
@@ -18,4 +17,5 @@ public ExchangeBybitLinearAPI(bool isUnifiedAccount)
 			IsUnifiedAccount = isUnifiedAccount;
 		}
 	}
+	public partial class ExchangeName { public const string BybitLinear = "BybitLinear"; }
 }

src/ExchangeSharp/API/Exchanges/Bybit/ExchangeBybitOptionAPI.cs

@@ -5,7 +5,6 @@
 
 namespace ExchangeSharp
 {
-	[ApiName(ExchangeName.Bybit)]
 	public class ExchangeBybitOptionAPI : ExchangeBybitV5Base
 	{
 		protected override MarketCategory MarketCategory => MarketCategory.Option;
@@ -18,4 +17,5 @@ public ExchangeBybitOptionAPI(bool isUnifiedAccount)
 			IsUnifiedAccount = isUnifiedAccount;
 		}
 	}
+	public partial class ExchangeName { public const string BybitOption = "BybitOption"; }
 }

src/ExchangeSharp/API/Exchanges/Bybit/ExchangeBybitSpotAPI.cs

@@ -5,7 +5,6 @@
 
 namespace ExchangeSharp
 {
-	[ApiName(ExchangeName.Bybit)]
 	public class ExchangeBybitSpotAPI : ExchangeBybitV5Base
 	{
 		protected override MarketCategory MarketCategory => MarketCategory.Spot;
@@ -18,4 +17,5 @@ public ExchangeBybitSpotAPI(bool isUnified)
 			IsUnifiedAccount = isUnified;
 		}
 	}
+	public partial class ExchangeName { public const string BybitSpot = "BybitSpot"; }
 }

src/ExchangeSharp/API/Exchanges/Bybit/ExchangeBybitV5Base.cs

@@ -160,7 +160,10 @@ protected override async Task<IEnumerable<MarketCandle>> OnGetCandlesAsync(strin
 			string url = "/v5/market/kline";
 			int maxLimit = 200;
 			limit ??= maxLimit;
-			if (limit.Value > maxLimit) { limit = maxLimit; }
+			if (limit.Value > maxLimit)
+			{
+				limit = maxLimit;
+			}
 			List<MarketCandle> candles = new List<MarketCandle>();
 			string periodString = PeriodSecondsToString(periodSeconds);
 			if (startDate == null)
@@ -244,7 +247,10 @@ protected override async Task<Dictionary<string, decimal>> OnGetAmountsAvailable
 			Dictionary<string, decimal> amounts = new Dictionary<string, decimal>(StringComparer.OrdinalIgnoreCase);
 
 			var accountBalances = result["list"].FirstOrDefault(i => i["accountType"].ToStringInvariant() == accType);
-			if (accountBalances == null) return amounts;
+			if (accountBalances == null)
+			{
+				return amounts;
+			}
 			if (IsUnifiedAccount.Value)
 			{
 				// All assets that can be used as collateral, converted to USD, will be here
@@ -253,7 +259,6 @@ protected override async Task<Dictionary<string, decimal>> OnGetAmountsAvailable
 			string balanceKey = accType == "SPOT" ? "free" : "availableToWithdraw";
 			foreach (var coin in accountBalances["coin"])
 			{
-
 				decimal amount = coin[balanceKey].ConvertInvariant<decimal>();
 				if (amount > 0m)
 				{

src/ExchangeSharp/Model/ExchangeOrderBook.cs

@@ -68,7 +68,7 @@ public ExchangeOrderPrice(BinaryReader reader)
     public sealed class ExchangeOrderBook
     {
 		/// <summary>
-		/// Needed to distinguish between fool book and deltas
+		/// Needed to distinguish between full book and deltas
 		/// </summary>
 		public bool IsFromSnapshot { get; set; }
 		public string ExchangeName { get; set; }