Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Incorrect inconsistent_values error on numeric columns #106

Closed
jpmckinney opened this issue Nov 14, 2014 · 0 comments · Fixed by #119
Closed

BUG: Incorrect inconsistent_values error on numeric columns #106

jpmckinney opened this issue Nov 14, 2014 · 0 comments · Fixed by #119

Comments

@jpmckinney
Copy link

If a numeric column has numbers with 8 digits (date_number), 14 digits (dateTime_number) or 23 digits (dateTime_nsec) and if those digits happen to be valid dates >10% of the time, then an inconsistent_values validation error is incorrectly reported.

Unless these date/time formats are extant (do we know any software that reads or writes CSV dates in this format?), they should be eliminated.

Note that this happily helps solve #105, and it is in fact a significant speed improvement after #103 (like 25% faster with #103).

@jpmckinney jpmckinney changed the title Incorrect inconsistent_values error on numeric columns BUG: Incorrect inconsistent_values error on numeric columns Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant