-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isis3 version defined in multiple places #517
Comments
Another location: |
It looks like this is still a problem. Specifically, https://github.com/USGS-Astrogeology/ISIS3/blob/dev/isis/CMakeLists.txt#L421 Looks like the libsisis.so is still trying to removeversion 3.6 even though at the top is 3.9. The fact that this has not been an issue suggests that the commands to execute the |
I am a bot that cleans up old issues that do not have activity. This issue has not received feedback in the last eleven months! If this is still a pertinent issue, please add a comment or add an emoji to an existing comment. In one month I will close this issue on it's birthday unless it has some activity. |
This has largely been resolved with #3992 and the meta.yaml is kind of intractable. |
The isis3 version is defined in 3 places that I could find:
isis/version
contains the version number, date, and build status (alpha, beta, stable)isis/CMakeLists.txt
contains VERSION, VERSION_DATE, and RELEASE_STAGE variablesisis/CMakeLists.txt
hard-codes the library version number (libisis3.6.0.${SO}
)These should be consolidated so we don't have to maintain 3 places for versioning.
Also, the isis3_dependencies repo defines versioning for isis3 in its
recipes/isis/meta.yaml
file.The text was updated successfully, but these errors were encountered: