Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isis3 version defined in multiple places #517

Closed
ihumphrey opened this issue Oct 30, 2018 · 5 comments
Closed

isis3 version defined in multiple places #517

ihumphrey opened this issue Oct 30, 2018 · 5 comments
Labels
good first issue Good for newcomers

Comments

@ihumphrey
Copy link

ihumphrey commented Oct 30, 2018

The isis3 version is defined in 3 places that I could find:

  • isis/version contains the version number, date, and build status (alpha, beta, stable)
  • isis/CMakeLists.txt contains VERSION, VERSION_DATE, and RELEASE_STAGE variables
  • isis/CMakeLists.txt hard-codes the library version number (libisis3.6.0.${SO})

These should be consolidated so we don't have to maintain 3 places for versioning.

Also, the isis3_dependencies repo defines versioning for isis3 in its recipes/isis/meta.yaml file.

@ihumphrey
Copy link
Author

Another location: isis/cmake/CMakeLists.txt

@jlaura jlaura added the good first issue Good for newcomers label Dec 10, 2018
@jlaura
Copy link
Collaborator

jlaura commented Sep 17, 2019

It looks like this is still a problem. Specifically, https://github.com/USGS-Astrogeology/ISIS3/blob/dev/isis/CMakeLists.txt#L421

Looks like the libsisis.so is still trying to removeversion 3.6 even though at the top is 3.9. The fact that this has not been an issue suggests that the commands to execute the rm are not needed?

@jessemapel
Copy link
Contributor

@jlaura See #3365 for the cmake version and library version non-sense. This has also gotten worse as it's defined in our conda-build recipe too 🎉

@ascbot
Copy link
Contributor

ascbot commented Sep 1, 2020

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last eleven months! If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

In one month I will close this issue on it's birthday unless it has some activity.

@jessemapel
Copy link
Contributor

This has largely been resolved with #3992 and the meta.yaml is kind of intractable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants