Merge pull request #28 from CyberfusionNL/1.84.0

Version 1.84.0

Author: dvdheiden

CHANGELOG.md

@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 this package and not the cluster API. See the changelog of the [cluster API](https://cluster-api.cyberfusion.nl/redoc#section/Changelog) 
 for detailed information.
 
+## [1.84.0]
+
+### Added
+
+- Return task collection on virtual host delete.
+
 ## [1.83.0]
 
 ### Added

README.md

@@ -2,7 +2,7 @@
 
 Client for the [Cyberfusion Cluster API](https://cluster-api.cyberfusion.nl/).
 
-This client was built for and tested on the **1.158** version of the API.
+This client was built for and tested on the **1.159.1** version of the API.
 
 ## Support
 

src/Client.php

@@ -20,7 +20,7 @@ class Client implements ClientContract
 {
     private const CONNECT_TIMEOUT = 60;
     private const TIMEOUT = 180;
-    private const VERSION = '1.83.0';
+    private const VERSION = '1.84.0';
     private const USER_AGENT = 'cyberfusion-cluster-api-client/' . self::VERSION;
 
     private Configuration $configuration;

src/Endpoints/VirtualHosts.php

@@ -178,30 +178,36 @@ public function update(VirtualHost $virtualHost): Response
 
     /**
      * @param int $id
+     * @param string|null $callbackUrl
      * @return Response
      * @throws RequestException
      */
-    public function delete(int $id): Response
+    public function delete(int $id, string $callbackUrl = null): Response
     {
-        // Log the affected cluster by retrieving the model first
-        $result = $this->get($id);
-        if ($result->isSuccess()) {
-            $clusterId = $result
-                ->getData('virtualHost')
-                ->getClusterId();
-
-            $this
-                ->client
-                ->addAffectedCluster($clusterId);
-        }
+        $url = Str::optionalQueryParameters(
+            sprintf(
+                'virtual-hosts/%d',
+                $id,
+            ),
+            ['callback_url' => $callbackUrl]
+        );
 
         $request = (new Request())
             ->setMethod(Request::METHOD_DELETE)
-            ->setUrl(sprintf('virtual-hosts/%d', $id));
+            ->setUrl($url);
 
-        return $this
+        $response = $this
             ->client
             ->request($request);
+        if (!$response->isSuccess()) {
+            return $response;
+        }
+
+        $taskCollection = (new TaskCollection())->fromArray($response->getData());
+
+        return $response->setData([
+            'taskCollection' => $taskCollection,
+        ]);
     }
 
     /**