Why using binary for 'application/javascript' and alike?

[Vadorequest]

I don't understand why you use a binary mime type for

const binaryMimeTypes = [
  'application/javascript',
  'application/json',
  'application/octet-stream',
  'application/xml',
  'font/eot',
  'font/opentype',
  'font/otf',
  'image/jpeg',
  'image/png',
  'image/svg+xml',
  'text/comma-separated-values',
  'text/css',
  'text/html',
  'text/javascript',
  'text/plain',
  'text/text',
  'text/xml'
];

I think it makes sense for image/* (because png/jpg are treated as binary format by API Gateway and won't be displayed without this) but I don't get why you use it on application/json or application/javascript at all, and I don't know what repercussions this may have on the behaviour of an application.

Could you explain the reason behind this? I would guess something like the following would be enough.

const binaryMimeTypes = [
  'application/octet-stream',
  'image/jpeg',
  'image/png',
  'text/comma-separated-values // unsure if that's binary format
];

Thank you!

[brettstack]

Excellent question. This is required to work with gzip compression, which the example uses.

[Vadorequest]

That is what I assumed, you use the compression express package/plugin.

Too bad it is required to manually list all MIME types because if everything is compressed, a simple * would be enough, since everything will be sent as gzip anyway.

[brettstack]

Agreed. I plan on making that change.

…

On Fri, Mar 9, 2018, 11:08 PM Vadorequest ***@***.***> wrote: That is what I assumed, you use the compression express package/plugin. Too bad it is required to manually list all MIME types because if everything is compressed, a simple * would be enough, since everything will be sent as gzip anyway. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#131 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABy6l532uUPyn4s15QWiOC0_Nfr0JMf0ks5tcn7dgaJpZM4SkDt1> .

[Vadorequest]

@brettstack I believe this is related to #70

[brettstack]

Added in #136