Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-7313] Fix merging accounts via GV #10999

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Feb 25, 2025

Purpose

Fix issues with users being used causing issues with request context.

This error:
https://sentry3.cos.io/organizations/cos/issues/50803/events/231c63d16d7e40de925fc9cadc25fa0e/

Changes

  • add parmeter that allows method outside request context
  • break out user merge tests and update them to set the GV waffle flag on

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-7313

@Johnetordoff Johnetordoff changed the base branch from feature/b-and-i-25-01 to develop February 25, 2025 16:38
@Johnetordoff Johnetordoff changed the title [ENG-7315] Fix merging accounts via GV [ENG-7313] Fix merging accounts via GV Feb 25, 2025
@Johnetordoff Johnetordoff marked this pull request as ready for review February 26, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant