[ENG-7305] Enable to Withdraw Preprint Again After the preprint has been unwithdrawn #10998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
requested changes
Feb 26, 2025
| @@ -591,6 +591,7 @@ def post(self, request, *args, **kwargs): | |||
|
|
|||
| from osf.utils.migrations import disable_auto_now_fields | |||
| with disable_auto_now_fields(): | |||
| preprint.requests.all().delete() | |||
There was a problem hiding this comment.
So is there not a middle ground between not deleting any requests and deleting all the requests?
There was a problem hiding this comment.
Yes, I think it is, in PreprintRequestCreateSerializer is a check for requests count, we can remove it or allow for multiple withdraw requests (not include active requests)
There was a problem hiding this comment.
To my mind, a more suitable option is to add check for active withdraw requests and, in case of no active ones, to allow for another. In this case there is no need for deleting requests, and on unwithdraw action, we can set machine_state of that request to rejected.
There was a problem hiding this comment.
I think we should remove just the withdrawal request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enable to Withdraw Preprint Again After the preprint has been unwithdrawn
Changes
TBD
QA Notes
TBD
Documentation
TBD
Side Effects
TBD
Ticket
(https://openscience.atlassian.net/browse/ENG-7305)