[ENG-7291] Update Contributor filter to filter on permissions #10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
requested changes
Feb 24, 2025
There was a problem hiding this comment.
This is good work, but I would request we make some additional changes to break up the test_filtering method into more individual test cases. I think what you have written already is good I'm just noticing that this method very long test_filtering method makes it hard to evaluate. So just a minor request to split test_filtering into test_filtering_permission_field_admin, test_filtering_permission_field_write etc. Thanks.
Johnetordoff
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update Contributor filter to filter on permissions
Changes
Added filter operator 'exact' for node contributor filtering
Added tests for exact permission filtering in contributor list
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-7291