Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOM_parameter_doc_* incomplete #121

Closed
aekiss opened this issue Mar 14, 2024 · 6 comments
Closed

MOM_parameter_doc_* incomplete #121

aekiss opened this issue Mar 14, 2024 · 6 comments
Labels
bug Something isn't working mom6 Related to MOM6 priority:med

Comments

@aekiss
Copy link
Contributor

aekiss commented Mar 14, 2024

In ACCESS-NRI/access-om3-configs@7dd28b1 I replaced MOM_input in https://github.com/COSIMA/MOM6-CICE6/tree/1deg_jra55do_ryf with the contents of MOM_parameter_doc.short plus a couple of things from MOM_parameter_doc.debugging.

MOM_parameter_doc.short is supposed to list all the non-default parameters, but as @minghangli-uni points out, it is missing MAX_ENT_IT, TOLERANCE_ENT and HMIX_MIN, so these didn't end up in the updated MOM_input despite having non-default values. They are also missing from MOM_parameter_doc.all which is supposed to include them.

MOM_input is easily fixed manually, but since this looks like a bug in MOM6 it should be fixed there.

@aekiss aekiss added bug Something isn't working mom6 Related to MOM6 labels Mar 14, 2024
@access-hive-bot
Copy link

This issue has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/namelist-configuration-discussion-meeting/1917/6

@access-hive-bot
Copy link

This issue has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/namelist-configuration-discussion-meeting/1917/9

@aekiss
Copy link
Contributor Author

aekiss commented Mar 15, 2024

from https://forum.access-hive.org.au/t/namelist-configuration-discussion-meeting/1917/9

MAX_ENT_IT and TOLERANCE_ENT - set to default (ie omit from MOM_input)
HMIX_MIN - add to MOM_input and leave as 2.0

@anton-seaice
Copy link
Contributor

anton-seaice commented Feb 20, 2025

We have done this now manually in most branches :

1deg_ryf ACCESS-NRI/access-om3-configs#161
1deg_iaf ACCESS-NRI/access-om3-configs#167
1deg_ryf_wombatlite ACCESS-NRI/access-om3-configs#168
025deg_ryf ACCESS-NRI/access-om3-configs#169

And will be captured in #283 and #284

I don't think there are missing parameters in MOM_paramater_short.doc anymore ?

@aekiss
Copy link
Contributor Author

aekiss commented Feb 21, 2025

Good to hear that MOM_paramater_doc.short now seems to be complete.

I'll note here for future reference that a few things (e.g. U_TRUNC_FILE, V_TRUNC_FILE , FATAL_UNUSED_PARAMS - see here) need copying from MOM_parameter_doc.debugging to MOM_input if set to non-default values - see #200 (comment)

@anton-seaice
Copy link
Contributor

There are some comments at the top of MOM_input on how to change each section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mom6 Related to MOM6 priority:med
Projects
Status: Done
Development

No branches or pull requests

4 participants