Skip to content

Add feature for not recognizing hostile group members as hostile #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BC46 opened this issue Nov 4, 2024 · 0 comments
Open

Add feature for not recognizing hostile group members as hostile #6

BC46 opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@BC46
Copy link
Owner

BC46 commented Nov 4, 2024

Currently there are the following issues in FL:

  • It's not possible to enter formation with a group member that's hostile to you.
  • The danger music is played when you are near a hostile team member. This makes it harder to notice that actual hostiles may come near you.
  • For hostile group members, you'll always see the attack reticle when hovering over them. This makes it easier to confuse group members for hostiles in dogfights for instance.
  • In general for friendly, neutral, and hostile group members, the pink "group" color is not honored when rendering the reticle.
    • The same can be said for a player who you are currently trading with (darker purple color).

Some notes:

common.dll, 6C396 EB to allow for formation with hostiles
freelancer.exe, 005552A8, 0045A4A8, checks if the current ship on the radar is hostile. if so, there is danger (is_player() function checks ship type too)
check if parent is CShip: get dword 0x4C and do an AND with 0x503
Or just call IObjInspectImpl is_player, then cast to cship

00679B88 = FlColor* pinkGroupColor
00679B9C = FlColor* purpleTradeColor

struct FlColor
{
	BYTE r, g, b, a;
}

Also note: Discovery apparently introduced a change where target locking won't work if you are aiming at a group member. I personally do not really see this as a quality of life improvement. For instance, if you wanted to do PvP with someone who happens to be your group member, you will be set at a huge disadvantage because you will not be able to aim properly. Of course a solution would be to temporarily leave the group, but what if you forget to do it? Hence it's important that when the features mentioned in this issue get implemented, it must be ensured that target locking continues to work.

@BC46 BC46 added the enhancement New feature or request label Nov 4, 2024
@BC46 BC46 changed the title Add feature for not recognizing group members as hostile Add feature for not recognizing hostile group members as hostile Nov 4, 2024
@BC46 BC46 self-assigned this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant