From 90199cfc8578cce310131279dc16d3a37bae8d83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Bene=C5=A1?= Date: Thu, 22 Aug 2024 09:05:30 +0200 Subject: [PATCH] Apply suggestions from code review --- noir-projects/aztec-nr/aztec/src/keys/public_keys.nr | 2 +- yarn-project/foundation/src/fields/point.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/noir-projects/aztec-nr/aztec/src/keys/public_keys.nr b/noir-projects/aztec-nr/aztec/src/keys/public_keys.nr index a1030c782222..119396cfcb95 100644 --- a/noir-projects/aztec-nr/aztec/src/keys/public_keys.nr +++ b/noir-projects/aztec-nr/aztec/src/keys/public_keys.nr @@ -34,7 +34,7 @@ impl Serialize for NpkM { } } -// Note: If we store npk_m_hash directly we can remove this trait implementation +// Note: If we store npk_m_hash directly we can remove this trait implementation. See #8091 impl Hash for NpkM { fn hash(self) -> Field { self.inner.hash() diff --git a/yarn-project/foundation/src/fields/point.ts b/yarn-project/foundation/src/fields/point.ts index 020eb0e4dd45..30cb3f5ab147 100644 --- a/yarn-project/foundation/src/fields/point.ts +++ b/yarn-project/foundation/src/fields/point.ts @@ -226,6 +226,7 @@ export class Point { /* eslint-enable camelcase */ } + // Used for IvpkM, OvpkM, NpkM and TpkM toWrappedNoirStruct() { /* eslint-disable camelcase */ return { inner: this.toNoirStruct() };