From 18d8d07f17aee63a8c7d88e553a4088a91bf8be4 Mon Sep 17 00:00:00 2001
From: Are Almaas <arealmaas@gmail.com>
Date: Fri, 11 Oct 2024 09:30:17 +0200
Subject: [PATCH] chore(slacknotifier): remove health checks from slack alerts
 (#1269)

<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

We are getting spammed by health-check alerts in Slack. For now these
are just probes that Kubernetes should handle the error of internally.

## Related Issue(s)

- #1261

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new parameter for improved configuration of the Slack
Notifier function app.
- Enhanced security with a system-assigned identity for the function
app.
	- Added a new module for managing application settings seamlessly.
- Implemented an exception alert rule to monitor and notify the
development team of issues.

- **Improvements**
- Enhanced resource management and monitoring capabilities for better
operational efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .azure/modules/functionApp/slackNotifier.bicep | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.azure/modules/functionApp/slackNotifier.bicep b/.azure/modules/functionApp/slackNotifier.bicep
index 6791d328b..48e84f8f3 100644
--- a/.azure/modules/functionApp/slackNotifier.bicep
+++ b/.azure/modules/functionApp/slackNotifier.bicep
@@ -161,6 +161,7 @@ var query = '''
                  | where not(customDimensions.['Service Type'] == 'API Management')),
                  (traces
                  | where severityLevel >= 3 or (severityLevel >= 2 and customDimensions.SourceContext startswith "Digdir"))
+                 | where operation_Name !startswith "GET /health/"
              | summarize Count = count()
                  by
                  Environment = tostring(customDimensions.AspNetCoreEnvironment),