Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loading state for dialog from altinn-components #1877

Closed
seanes opened this issue Mar 3, 2025 · 1 comment
Closed

Use loading state for dialog from altinn-components #1877

seanes opened this issue Mar 3, 2025 · 1 comment
Assignees
Labels
dev developer task

Comments

@seanes
Copy link
Contributor

seanes commented Mar 3, 2025

Remove InboxItemPageSkeleton (and all files related) and add prop loading to InboxItemDetail.
InboxItemDetail should return an article with DialogHeader and DialogBody in their loading state as a replacement for current InboxItemPageSkeleton.

@seanes seanes added the dev developer task label Mar 3, 2025
@seanes seanes self-assigned this Mar 3, 2025
@seanes seanes moved this from New issues to Doing in Dialogporten / Arbeidsflate Mar 3, 2025
@seanes seanes moved this from Doing to Code Review og PR in Dialogporten / Arbeidsflate Mar 4, 2025
@seanes seanes moved this from Code Review og PR to Testing in Dialogporten / Arbeidsflate Mar 5, 2025
@LeifHelstad
Copy link
Contributor

Test

Observerer endringene i koden via PR.
Observerer ingen endring i arbeidsflaten i testmiljøet knyttet til dette.
🟢 Dette er heller ikke en endring som skal merkes. Så i seg selv er denne ok.
Så er det noen småting rundt for eksempel telling av elementer ved første visning versus refresh. Om det skyldes dette eller noen annet er umulig å si fra et black-box perspektiv, og de observasjonene følges uansett opp via separate issues.

@LeifHelstad LeifHelstad moved this from Testing to Done in Dialogporten / Arbeidsflate Mar 7, 2025
@LeifHelstad LeifHelstad closed this as completed by moving to Done in Dialogporten / Arbeidsflate Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev developer task
Projects
Status: Done
Development

No branches or pull requests

2 participants